We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In https://github.com/ethereum/evmc/blob/master/include/evmc/evmc.h#L164 evmc_block_hash_fn returns 1 on success, 0 on failure.
evmc_block_hash_fn
Compared to that, evmc_status_code uses the POSIX style 0 for success, anything else for failure.
evmc_status_code
This kind of indicates an inconsistency. evmc_block_hash_fn tries to map a boolean into a uint, that's why.
A solution could be either using stdbool.h or creating an enum to replicate it: evmc_bool.
stdbool.h
evmc_bool
The text was updated successfully, but these errors were encountered:
I considered this and I'm not convinced because I'm not sure we should introduce another bool type.
Sorry, something went wrong.
stdbool.h: http://pubs.opengroup.org/onlinepubs/009604499/basedefs/stdbool.h.html, not sure which C standard introduced it.
Should check stdbool.h with Go and rust-bindgen.
The stdbool.h is good for:
I will try this one.
chfast
No branches or pull requests
In https://github.com/ethereum/evmc/blob/master/include/evmc/evmc.h#L164
evmc_block_hash_fn
returns 1 on success, 0 on failure.Compared to that,
evmc_status_code
uses the POSIX style 0 for success, anything else for failure.This kind of indicates an inconsistency.
evmc_block_hash_fn
tries to map a boolean into a uint, that's why.A solution could be either using
stdbool.h
or creating an enum to replicate it:evmc_bool
.The text was updated successfully, but these errors were encountered: