Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bool type instead of int with 1 and 0 #138

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Use bool type instead of int with 1 and 0 #138

merged 1 commit into from
Sep 6, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 5, 2018 •
edited
Loading

Resolves #131
Resolves #135

@chfast chfast requested a review from axic September 5, 2018 21:26
axic
axic reviewed Sep 5, 2018
View reviewed changes
include/evmc/evmc.h Outdated
@@ -11,6 +11,7 @@
#ifndef EVMC_H
#define EVMC_H

#include <stdbool.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but could add Definition of bool, true, false here :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed self explained.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the comment.

@chfast chfast merged commit 83a679c into master Sep 6, 2018
@axic axic deleted the bool branch September 6, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @axic