Generalize loader searching algorithm #119
Conversation
Allow loader to shorten the name word by word to the point where only single word is left.
| * - if function not found, the _base name_ is shorten by skipping the first word separated by "_": | ||
| * "interpreter", | ||
| * - then, the function of the shorter name "evmc_create_" + _base name_ is searched in the library: | ||
| * "evmc_create_interpreter", |
There was a problem hiding this comment.
So what exactly is the logic here? It removes the prefixes? example off example_interpreter
There was a problem hiding this comment.
But also a_b_c_d -> b_c_d -> c_d -> d.
There was a problem hiding this comment.
evmc-example-vm :) I want it to come up with function name evmc_create_example_vm() while previously it tried only evmc_create_evmc_example_vm() and evmc_create_vm().
There was a problem hiding this comment.
I think that may not be the most sound reasoning :)
Why not just name the file example-vm (and the creator appropriately) and be done with it?
There was a problem hiding this comment.
For 3 reasons:
- I don't want to name the library example-vm in case it is going to be installed.
- This code looks better than before.
- Even the author of loader (me) was no able to remember how exactly it was working before so Host example #116 does not work.
There was a problem hiding this comment.
Didn't notice the old code was doing the very same weird logic.
There was a problem hiding this comment.
It was, but not fully. It was skipping all leading words except the last one.
| if (!shorter_name_pos) | ||
| break; | ||
|
|
||
| memmove(base_name, shorter_name_pos + 1, strlen(shorter_name_pos) + 1); | ||
| } | ||
|
|
||
| if (!create_fn) |
There was a problem hiding this comment.
Practically this part wouldn't be needed if in the above loop on !short_name_pos base_name is set to \0.
There was a problem hiding this comment.
True. I will check it out.
There was a problem hiding this comment.
No, it will get messy. I would need to add another loop terminating condition (like strlen == 0) and we don't want to check for "evmc_create_" but "evmc_create".
Also, the naming convention will change soon and we might want to try "evmc_create" first.
Allow loader to shorten the name word by word to the point where only single word is left.