Introduce evmc_capabilities and emvc_get_capabilities_fn #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chfast I've realised I wont have time to finish this now, if you want to take over. |
axic
commented
Sep 6, 2018
include/evmc/evmc.h
Outdated
| * and its value MAY be influenced by calls to set_option. | ||
| * | ||
| * @param instance The EVM instance. | ||
| * @return The supported capabilities of the VM, @see ::evmc_capabilities. |
There was a problem hiding this comment.
I think the @see part is needed here given it doesn't return an enum.
axic
commented
Sep 8, 2018
include/evmc/evmc.h
Outdated
| EVMC_CAPABILITY_EVM1 = 1, /**< The VM is capable of executing EVM1 bytecode. */ | ||
| EVMC_CAPABILITY_EWASM = 2 /**< The VM is capable of execution ewasm bytecode. */ | ||
| EVMC_CAPABILITY_EVM1 = (1u << 0), /**< The VM is capable of executing EVM1 bytecode. */ | ||
| EVMC_CAPABILITY_EWASM = (2u << 1) /**< The VM is capable of execution ewasm bytecode. */ |
There was a problem hiding this comment.
I like pushing ones left by X bits, e.g.:
1 << 01 << 11 << 2
...
|
@axic Please review my changes. |
chfast
approved these changes
Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141.