Rename uint256be to bytes32 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Sep 6, 2018
include/evmc/evmc.h
Outdated
| /** | ||
| * The alias for evmc_bytes32 to represent a big-endian 256-bit integer. | ||
| */ | ||
| typedef struct evmc_bytes32 evmc_uint256be; |
There was a problem hiding this comment.
So I am thinking perhaps we should have struct __evmc_bytes32 {..} and then two typedefs (and the same applies to evmc_address) so that it is consistent requiring (or not) struct in further use cases.
Right now it is weird that one has to use struct evmc_bytes32 a; and evmc_uint256be a;
There was a problem hiding this comment.
Also wonder if we do have the shared underlying type, operators applied to them propagate to the two typedefs?
There was a problem hiding this comment.
These are the same types effectively. Yes, it feels weird to me too.
gumb0
reviewed
Sep 7, 2018
|
|
||
| /** | ||
| * The optional value used in new contract address construction. | ||
| * | ||
| * Ignored unless kind is EVMC_CREATE2. | ||
| */ | ||
| struct evmc_uint256be create2_salt; | ||
| evmc_bytes32 create2_salt; | ||
| }; | ||
|
|
||
|
|
||
| /** The transaction and block data for execution. */ | ||
| struct evmc_tx_context |
There was a problem hiding this comment.
Maybe typedef this one, too, to write evmc_tx_context instead od struct evmc_tx_context?
axic
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
Some things to consider
evmc_hash256for explicit crypto-hashes.evmc_bytes32andevmc_addressto avoidstructprefix.