cpp: Add Host interface for the Host side #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
cpp-host-interface
branch
3 times, most recently
from
2cbd68b
to
886cecc
Compare
gumb0
reviewed
Apr 1, 2019
examples/example_host.cpp
Outdated
| account_exists, get_storage, set_storage, get_balance, get_code_size, get_code_hash, | ||
| copy_code, selfdestruct, call, get_tx_context, get_block_hash, emit_log, | ||
| public: | ||
| bool account_exists(const evmc_address& addr) noexcept override |
There was a problem hiding this comment.
Yes, I noticed. Decided to go override because more common. I tend to not to use less common C++ features in examples. Although, in this case it might be good suggestion to use final here.
gumb0
reviewed
Apr 1, 2019
include/evmc/evmc.hpp
Outdated
| /// Wrapper around EVMC host context / host interface. | ||
| class host | ||
| /// | ||
| /// To be used by VM implementations as better alternative than using ::evmc_context directly. |
gumb0
reviewed
Apr 1, 2019
include/evmc/evmc.hpp
Outdated
| { | ||
| context->host->emit_log(context, &address, data, data_size, topics, topics_count); | ||
| } | ||
| }; | ||
|
|
||
| /// Abstract class to be used by Host implementations. Hides ::evmc_context vtable. |
There was a problem hiding this comment.
Documentation here could be better. evmc_context doesn't have vtable.
Better explicitly point out, that this class should be derived when implementing Host
chfast
force-pushed
the
cpp-host-interface
branch
from
886cecc
to
a0d0591
Compare
chfast
force-pushed
the
cpp-host-interface
branch
from
a0d0591
to
0c1e13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Host part of the C++ API.
The plan was different, to keep it physically separated, but I realized both Host and VM sides of the API implement the same interface...
HostInterface.This introduces some naming issues. We have
HostInterfaceas pure C++ interfaceHostContextas wrapper for the host context pointer to be used by VMs, implementsHostInterface.Host- the abstract class for Host implementations, implementsHostInterface.Suggestions for better names welcome.
Effectively closes #189.
The only tunes left for C++ are aliases like
evmc::address = evmc_address, merging helpers.hpp, maybe add better types forevmc_address,evmc_uint256be, etc.