ci: Test C++17 mode in MSVC #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
msvc-cxx17
branch
4 times, most recently
from
5688722
to
189eda5
Compare
axic
reviewed
May 6, 2019
| @@ -15,7 +15,7 @@ TEST(instructions, homestead_hard_fork) | |||
|
|
|||
| EXPECT_EQ(f[OP_DELEGATECALL].gas_cost, -1); | |||
| EXPECT_EQ(h[OP_DELEGATECALL].gas_cost, 40); | |||
| EXPECT_EQ(fn[OP_DELEGATECALL], nullptr); | |||
| EXPECT_TRUE(fn[OP_DELEGATECALL] == nullptr); | |||
There was a problem hiding this comment.
Printing of nullptr does not compile in MSVC because of the GTest issue.
axic
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
This is GTest issue: google/googletest#1616