cpp: Rename result::raw() to result::release_raw() #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
May 15, 2019
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## [6.2.2] - unreleased | |||
|
|
|||
| - Changed: [[#293](https://github.com/ethereum/evmc/pull/293)] | |||
| In C++ API `evmc::result::raw()` renamed to `evmc::result::release_raw()`. | |||
There was a problem hiding this comment.
I think it is, but the comment should at least be merged into 6.2
There was a problem hiding this comment.
It's breaking, but 6.2 has broken C++ API anyway. Besides, this method is used internally.
There was a problem hiding this comment.
Just checked, raw was introduced in 6.2.1 via #257. I don't think renaming it is fixing a bug, the bug was fixed before the renaming, wasn't it?
chfast
force-pushed
the
cpp_result_release_raw
branch
from
e2c87b5
to
3ffadec
Compare
|
Based on |
gumb0
approved these changes
May 16, 2019
jakelang
approved these changes
May 20, 2019
|
|
chfast
force-pushed
the
cpp_result_release_raw
branch
from
3ffadec
to
a70e297
Compare
chfast
changed the title
|
Renamed to |
|
But "acquire" is the opposite of what happens. Maybe it could look fine if it were a free function like |
chfast
force-pushed
the
cpp_result_release_raw
branch
from
a70e297
to
3ffadec
Compare
chfast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.