Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: introduce ExecutionMessage wrapper #324

Merged
merged 2 commits into from
Jun 25, 2019
Merged

rust: introduce ExecutionMessage wrapper #324

merged 2 commits into from
Jun 25, 2019

Conversation

axic
Copy link
Member

@axic axic commented Jun 19, 2019 •
edited
Loading

Part of #319.

@axic axic requested a review from jakelang June 19, 2019 18:20
@axic axic marked this pull request as ready for review June 25, 2019 17:51
jakelang
jakelang reviewed Jun 25, 2019
View reviewed changes
bindings/rust/evmc-vm/src/lib.rs
assert!(message.input_size == 0);
None
} else {
// TODO: what to do if input_size is 0?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panic.

@axic axic merged commit 88f2a1d into master Jun 25, 2019
@axic axic deleted the rust-message branch June 25, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelang jakelang jakelang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axic @jakelang