rust: support ParitalEq, Default, Hash on certain ffi types #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could also force deriving in bindgen with (derive_partialeq(true)), but that would insert it for complex structures we don't want it for, such evmc_message and blacklisthing those is tedious and error prone in case EVMC introduces new structures.
Same as with PartialEq: this may be done via bindgen in the future.
jakelang
reviewed
Jul 5, 2019
| // TODO: with bindgen's interface improving these may be moved to | ||
| // bindgen configuration | ||
|
|
||
| impl PartialEq for evmc_address { |
There was a problem hiding this comment.
Implementing traits for bindgen-declared types is not the best approach IMO.
There was a problem hiding this comment.
It is explained in the comment above and the commit log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.