Deprecate tracing API #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
deprecate_tracing_api
branch
2 times, most recently
from
d97f3a7
to
9b419e0
Compare
chfast
force-pushed
the
deprecate_tracing_api
branch
2 times, most recently
from
43e6f50
to
147fd1a
Compare
chfast
commented
Aug 5, 2019
include/evmc/evmc.h
Outdated
| */ | ||
| EVMC_DEPRECATED |
There was a problem hiding this comment.
We cannot put [[deprecated]] attribute here because it makes the evmc_instance non-constuctable in some compilers: https://circleci.com/gh/ethereum/evmc/13261.
chfast
force-pushed
the
deprecate_tracing_api
branch
from
147fd1a
to
becf562
Compare
gumb0
reviewed
Aug 5, 2019
include/evmc/evmc.h
Outdated
| @@ -991,6 +991,10 @@ struct evmc_instance | |||
| * Optional pointer to function setting the EVM instruction tracer. | |||
| * | |||
| * If the EVM does not support this feature the pointer can be NULL. | |||
| * | |||
| * @deprecated | |||
| * The tracing API from EVMC 6 has been deprecated as there have been some | |||
There was a problem hiding this comment.
It's not deprecated in 6.2, should this say from EVMC 6.3 ?
|
What about |
We can only use |
chfast
force-pushed
the
deprecate_tracing_api
branch
from
becf562
to
0569d97
Compare
chfast
force-pushed
the
deprecate_tracing_api
branch
from
0569d97
to
b12e24f
Compare
gumb0
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260.