Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: add LoadAndConfigure method #404

Merged
merged 1 commit into from
Aug 16, 2019
Merged

go: add LoadAndConfigure method #404

merged 1 commit into from
Aug 16, 2019

Conversation

axic
Copy link
Member

@axic axic commented Aug 16, 2019

No description provided.

@axic axic force-pushed the go-load branch 2 times, most recently from 4a856f8 to 69a1800 Compare August 16, 2019 09:58
@axic axic marked this pull request as ready for review August 16, 2019 09:59
@axic axic requested a review from chfast August 16, 2019 09:59
@axic axic mentioned this pull request Aug 16, 2019
Closed
chfast
chfast reviewed Aug 16, 2019
View reviewed changes
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be included in 6.3.1? If yes, target release/6.3 branch. I believe we should have it in the EVMC PR in geth.

Add CHANGELOG entry.

@axic
Copy link
Member Author

axic commented Aug 16, 2019

Should this be included in 6.3.1? If yes, target release/6.3 branch. I believe we should have it in the EVMC PR in geth.

Semantic versioning wise 6.4.0 would be more appropriate because it is a new feature, but I'm fine with 6.3.1

@chfast
Copy link
Member

chfast commented Aug 16, 2019

Semantic versioning wise 6.4.0 would be more appropriate because it is a new feature, but I'm fine with 6.3.1

Let's have in 6.3.1 then.

@axic axic changed the base branch from master to release/6.3 August 16, 2019 19:51
@axic
Copy link
Member Author

axic commented Aug 16, 2019

Let's have in 6.3.1 then.

@chfast done.

@chfast chfast merged commit 41a59ca into release/6.3 Aug 16, 2019
@chfast chfast deleted the go-load branch August 16, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axic @chfast