Rename evmc_instance -> evmc_vm #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
rename_instance
branch
5 times, most recently
from
e941715
to
e90c13a
Compare
chfast
force-pushed
the
rename_instance
branch
from
e90c13a
to
77a2a6e
Compare
chfast
commented
Sep 25, 2019
| { | ||
| ec = set_error(EVMC_LOADER_INSTANCE_CREATION_FAILURE, | ||
| "creating EVMC instance of %s has failed", filename); | ||
| ec = set_error(EVMC_LOADER_VM_CREATION_FAILURE, "creating EVMC VM of %s has failed", |
There was a problem hiding this comment.
I'm not sure about this error message.
There was a problem hiding this comment.
would be great if it could mention the name of the function it called, but it doesn't look easy
| @@ -408,12 +408,12 @@ class VM | |||
| } | |||
|
|
|||
| private: | |||
| evmc_instance* m_instance = nullptr; | |||
| evmc_vm* m_instance = nullptr; | |||
There was a problem hiding this comment.
I have left the name m_instance because m_vm would be worse. This can also be m_handle (as in Go) or m_vm_ptr.
chfast
force-pushed
the
rename_instance
branch
2 times, most recently
from
b9f3582
to
1d4e084
Compare
gumb0
approved these changes
Sep 25, 2019
chfast
force-pushed
the
rename_instance
branch
from
1d4e084
to
28dfad3
Compare
|
What was the reasoning behind this? |
Looks better. Instance is like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.