Support CREATE2 opcode in Constantinople #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to add it to instructions lib. |
chfast
previously requested changes
Jul 24, 2018
include/evmc/evmc.h
Outdated
| @@ -70,7 +70,8 @@ enum evmc_call_kind | |||
| EVMC_CALL = 0, /**< Request CALL. */ | |||
| EVMC_DELEGATECALL = 1, /**< Request DELEGATECALL. The value param ignored. */ | |||
| EVMC_CALLCODE = 2, /**< Request CALLCODE. */ | |||
| EVMC_CREATE = 3 /**< Request CREATE. Semantic of some params changes. */ | |||
| EVMC_CREATE = 3, /**< Request CREATE. Semantic of some params changes. */ | |||
There was a problem hiding this comment.
You can remove the "Semantic of some params changes" part in both cases.
There was a problem hiding this comment.
I think these should state which evmc_revision they are valid in (frontier, homestead, byzantium, constantinople).
chfast
reviewed
Jul 25, 2018
include/evmc/evmc.h
Outdated
| * | ||
| * Ignored unless kind == EVMC_CREATE2. | ||
| */ | ||
| struct evmc_uint256be salt; |
There was a problem hiding this comment.
How about we name it create_salt?
There was a problem hiding this comment.
create2_salt 👍
Similarly to create_address.
axic
reviewed
Jul 25, 2018
include/evmc/evmc.h
Outdated
| /** | ||
| * The optional value used in new contract address construction. | ||
| * | ||
| * Ignored unless kind == EVMC_CREATE2. |
axic
reviewed
Jul 25, 2018
| @@ -12,7 +12,6 @@ static_assert(sizeof(evmc_uint256be) == 32, "evmc_uint256be is too big"); | |||
| static_assert(sizeof(evmc_address) == 20, "evmc_address is too big"); | |||
| static_assert(sizeof(evmc_result) <= 64, "evmc_result does not fit cache line"); | |||
| static_assert(sizeof(evmc_instance) <= 64, "evmc_instance does not fit cache line"); | |||
| static_assert(sizeof(evmc_message) <= 18 * 8, "evmc_message not optimally packed"); | |||
There was a problem hiding this comment.
Should this be kept with an updated size?
There was a problem hiding this comment.
It does not anything useful. I was just checking obvious struct fields alignment.
|
Renamed to |
|
This also needs an ABI version bump. |
|
Bumped ABI version to 2 |
axic
approved these changes
Jul 25, 2018
chfast
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.