Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpp: Require the host interface for HostContext be passed by reference #451

Merged
merged 2 commits into from
Nov 11, 2019
Merged

cpp: Require the host interface for HostContext be passed by reference #451

merged 2 commits into from
Nov 11, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented Nov 10, 2019 •
edited
Loading

Pass evmc_host_interface by reference to evmc::HostContext to make explicit that this pointer must not be null.

@chfast chfast marked this pull request as ready for review November 10, 2019 10:31
@chfast chfast requested review from gumb0 and axic November 10, 2019 10:31
@chfast chfast merged commit af16e9d into master Nov 11, 2019
@chfast chfast deleted the cpp branch November 11, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @axic