Java bindings refactoring #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
java-refactor
branch
2 times, most recently
from
f767e4e
to
4b0bcc8
Compare
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
==========================================
- Coverage 91.97% 91.93% -0.04%
==========================================
Files 20 20
Lines 3089 3076 -13
==========================================
- Hits 2841 2828 -13
Misses 248 248 |
chfast
reviewed
Dec 13, 2019
axic
force-pushed
the
java-refactor
branch
2 times, most recently
from
aac2171
to
7e05807
Compare
|
Sorry, I can't really review C code, not my specialty. I would love to try this code out at some point. |
chfast
requested changes
May 7, 2020
|
@chfast addressed, squashed, should be ready? |
chfast
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.