cmake: Bump minimum required version to 3.10 #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chfast
commented
Dec 13, 2019
chfast
commented
- We are using GoogleTest module introduced in 3.9.
- None of Debian / Ubuntu distributions versions provides CMake 3.9. The 3.10 is selected because this is the version provided in Ubuntu 18.04 LTS.
- We are using GoogleTest module introduced in 3.9. - None of Debian / Ubuntu distributions versions provides CMake 3.9. The 3.10 is selected because this is the version provided in Ubuntu 18.04 LTS.
|
Is this closing #471? |
axic
approved these changes
Dec 13, 2019
No. It simply documents the current status (CMake 3.9 is required currently if you want to build everything). This might be good enough for EVMC 7.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.