Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java: tiny bits of clean up to the host implementation #541

Merged
merged 4 commits into from
Sep 30, 2020
Merged

java: tiny bits of clean up to the host implementation #541

merged 4 commits into from
Sep 30, 2020

Conversation

axic
Copy link
Member

@axic axic commented Sep 28, 2020

No description provided.

@axic axic requested review from atoulme and chfast September 28, 2020 16:27
@axic axic force-pushed the java-cleanup branch 3 times, most recently from edcefb2 to 21019df Compare September 28, 2020 16:31
@axic
Copy link
Member Author

axic commented Sep 28, 2020

I think all the cases where CopyDataToJava is used it needs to be confirmed whether the object must be freed or not. In some cases it is freed, in others it is not.

@axic axic changed the title java: tiny bits of clean to the host implementation java: tiny bits of clean up to the host implementation Sep 28, 2020
atoulme
atoulme approved these changes Sep 29, 2020
View reviewed changes
Copy link
Collaborator

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chfast
chfast reviewed Sep 29, 2020
View reviewed changes
bindings/java/c/host.c Outdated Show resolved Hide resolved
@axic axic requested a review from chfast September 29, 2020 22:25
@axic axic merged commit 2166cc2 into master Sep 30, 2020
@axic axic deleted the java-cleanup branch September 30, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

@atoulme atoulme atoulme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axic @atoulme @chfast