java: remove code_size argument from execute() #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
java-execute-size
branch
2 times, most recently
from
5209d81
to
602575e
Compare
chfast
requested changes
Oct 10, 2020
axic
force-pushed
the
java-execute-size
branch
from
602575e
to
a10ebed
Compare
chfast
approved these changes
Oct 12, 2020
axic
force-pushed
the
java-execute-size
branch
2 times, most recently
from
03a4fe6
to
b328832
Compare
chfast
approved these changes
Oct 13, 2020
axic
commented
Oct 13, 2020
| @@ -114,11 +113,11 @@ native void execute( | |||
| * <p>This allows the context to managed in one method | |||
| */ | |||
| public synchronized ByteBuffer execute( | |||
| HostContext context, int rev, ByteBuffer msg, ByteBuffer code, int size) { | |||
There was a problem hiding this comment.
Note: this is a breaking change, but the Java binding we have is not stable enough and more changes are coming.
Everything merged so far were non-breaking changes.
axic
force-pushed
the
java-execute-size
branch
from
b328832
to
1b5bc7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.