Add EVMC_TRAP_INSTRUCTION error code #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Aug 10, 2018
include/evmc/evmc.h
Outdated
| * This is useful for WebAssembly implementations, where the `unreachable` | ||
| * instruction and various execution errors are turned into a trap. | ||
| */ | ||
| EVMC_TRAP_INSTRUCTION = 14, |
There was a problem hiding this comment.
Should this be merged with EVMC_INVALID_INSTRUCTION?
There was a problem hiding this comment.
Rather not, because trap can be caused not only by a contract design.
There was a problem hiding this comment.
Decision: use EVMC_UNREACHABLE_INSTRUCTION here.
There was a problem hiding this comment.
In addition we could have EVMC_WEBASSEMBLY_TRAP for the generic trap case as specified by the wasm spec.
|
I'm not sure this is so great idea, because it only reference to the way the exception was implemented in Ewasm. If you cannot distinguish division by zero (wasm builtin trap condition) from ones caused by contract code explicitly, you might want to use generic |
|
@chfast updated. |
chfast
approved these changes
Aug 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.