java: do not abort, but throw an exception in all cases in EvmcVm.create() #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
approved these changes
Mar 22, 2021
axic
force-pushed
the
java-create-exception
branch
from
212e76f
to
78fa119
Compare
…ate() Co-authored-by: Antoine Toulme <[email protected]>
axic
force-pushed
the
java-create-exception
branch
from
78fa119
to
3477afe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #555.
#555 will ultimate replace the code in
create(), but nevertheless this seems to be a nice intermediate step we can merge now, while #555 could take a bit of work 😬