Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mocked_host: create account in set_storage if non-existent #594

Merged
merged 3 commits into from
May 6, 2021
Merged

mocked_host: create account in set_storage if non-existent #594

merged 3 commits into from
May 6, 2021

Conversation

axic
Copy link
Member

@axic axic commented Apr 30, 2021

No description provided.

@axic axic marked this pull request as ready for review April 30, 2021 20:00
axic
axic commented May 4, 2021
View reviewed changes
Copy link
Member Author

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should extend cmd::run with an ether transfer option and have tests that a) account is preserved with balance on create; b) on balance + storage setting.

This can be done in a further PR since it requires more changes.

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #594 (94ad51b) into master (2c6a0f8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
+ Coverage   93.65%   93.67%   +0.02%     
==========================================
  Files          25       25              
  Lines        3764     3780      +16     
==========================================
+ Hits         3525     3541      +16     
  Misses        239      239

@chfast chfast merged commit 53f1fea into master May 6, 2021
@chfast chfast deleted the mockedhost-new-storage branch May 6, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axic @chfast