Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EVMC_LATEST_STABLE_REVISON #605

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Add EVMC_LATEST_STABLE_REVISON #605

merged 1 commit into from
Jun 28, 2021

Conversation

chfast
Copy link
Member

@chfast chfast commented Jun 28, 2021 •
edited
Loading 

    /**
     * The latest known EVM revision with finalized specification.
     *
     * This is handy for EVM tools to always use the latest revision available.
     */
    EVMC_LATEST_STABLE_REVISION = EVMC_LONDON

@chfast chfast requested review from yperbasis, gumb0 and axic June 28, 2021 11:39
@codecov
Copy link

codecov bot commented Jun 28, 2021 •
edited
Loading

Codecov Report

Merging #605 (41484db) into master (bdcf0d0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #605   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          24       24           
  Lines        3971     3971           
=======================================
  Hits         3801     3801           
  Misses        170      170

Base automatically changed from shanghai to master June 28, 2021 11:47
@chfast chfast merged commit 1a5a7f8 into master Jun 28, 2021
@chfast chfast deleted the latest_stable_rev branch June 28, 2021 12:07
yperbasis
yperbasis approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add something like

_Static_assert(EVMC_LATEST_STABLE_REVISION <= EVMC_MAX_REVISION);

@chfast
Copy link
Member Author

chfast commented Jun 28, 2021

I'd add something like

_Static_assert(EVMC_LATEST_STABLE_REVISION <= EVMC_MAX_REVISION);

Make sense. Added in #606 but in C++. I don't want to place it in C as that requires C11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yperbasis yperbasis yperbasis approved these changes

@axic axic axic approved these changes

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @axic @yperbasis