go: create2_salt is not required for execution #612
Merged
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
commented
Jul 16, 2021
| @@ -42,7 +42,7 @@ static struct evmc_result execute_wrapper(struct evmc_vm* vm, | |||
| input_data, | |||
| input_size, | |||
| *value, | |||
| *create2_salt, | |||
| {{0}}, // create2_salt: not required for execution | |||
There was a problem hiding this comment.
I changed that from the original commit because = {} is not valid ISO C syntax.
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 24 24
Lines 3971 3971
=======================================
Hits 3801 3801
Misses 170 170 |
yperbasis
approved these changes
Jul 16, 2021
gumb0
reviewed
Jul 16, 2021
gumb0
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled from #611.