Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Introduce EvmcVm::set_option #614

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Aug 3, 2021

No description provided.

@vorot93 vorot93 changed the title Rust set option Rust: EvmcVm::set_option Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #614 (ab46608) into master (975b52a) will increase coverage by 2.87%.
The diff coverage is n/a.

❗ Current head ab46608 differs from pull request most recent head ae28282. Consider uploading reports for the commit ae28282 to get more accurate results

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   92.86%   95.73%   +2.87%     
==========================================
  Files          24       24              
  Lines        3574     3987     +413     
  Branches      367        0     -367     
==========================================
+ Hits         3319     3817     +498     
- Misses        146      170      +24     
+ Partials      109        0     -109     

Copy link

@DONALDSULLENDER DONALDSULLENDER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verry good

@axic
Copy link
Member

axic commented May 6, 2022

Just in time, a year hasn't passed yet! 😓

Rebased and split this into two PRs, one adding the feature, and the other is the cleanup/refactoring (will open a PR for it).

@axic axic changed the title Rust: EvmcVm::set_option rust: Introduce EvmcVm::set_option May 6, 2022
@axic axic merged commit 7016d07 into ethereum:master May 6, 2022
@vorot93 vorot93 deleted the rust-set-option branch May 6, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants