Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify evmc_message::code_address usage #615

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Clarify evmc_message::code_address usage #615

merged 1 commit into from
Sep 8, 2021

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 7, 2021

  • Clarifies the documentation around evmc_message::code_address and other evmc_message fields.
  • Fixes the usage of code_address vs destination in the "precompiles vm" example.
  • Resolves the issue reported in Add code_address to evmc_message #611 (comment).

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #615 (ab5a01a) into master (54bf895) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   95.73%   95.73%           
=======================================
  Files          24       24           
  Lines        3987     3987           
=======================================
  Hits         3817     3817           
  Misses        170      170           

@chfast
Copy link
Member Author

chfast commented Sep 7, 2021

@jlokier, please check if this clarifies the situation around precompiles implementation.

Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also makes sense to change the description of EVMC_CAPABILITY_PRECOMPILES to say
"... for the range of code addresses" instead of "... for the range of destination addresses".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants