loader: Introduce error code for initialization #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 24 24
Lines 3986 3986
=======================================
Hits 3816 3816
Misses 170 170 |
Introduce special loader error code EVMC_LOADER_UNSPECIFIED_ERROR for initializing evmc_loader_error_code objects. This allows defensive usage pattern where user init error code to a value other than EVMC_LOADER_SUCCESS what protects against a misbehaving loader implementation.
yperbasis
approved these changes
Dec 20, 2021
gumb0
reviewed
Dec 22, 2021
| @@ -21,7 +21,10 @@ extern "C" { | |||
| /** The function pointer type for EVMC create functions. */ | |||
| typedef struct evmc_vm* (*evmc_create_fn)(void); | |||
|
|
|||
| /** Error codes for the EVMC loader. */ | |||
| /// Error codes for the EVMC loader. | |||
There was a problem hiding this comment.
/// for comments are not used anywhere else in this file
There was a problem hiding this comment.
I noticed, but I wanted to use // everywhere since we enabled C99.
So as I understand this allows to distinguish "loader did nothing" from "loader returned success". |
Yes. This seems better than |
gumb0
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce special loader error code EVMC_LOADER_UNSPECIFIED_ERROR
for initializing evmc_loader_error_code objects. This allows defensive
usage pattern where user init error code to a value other than
EVMC_LOADER_SUCCESS what protects against a misbehaving loader
implementation.
Go and Java bindings use new value. Rust bindings do not have EVMC loader support.