java: Fix get_block_hash implementation #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to have a typo triggering get_code_hash. Also removed the _fn suffix. Co-authored-by: Alex Beregszaszi <[email protected]>
axic
commented
Jun 1, 2022
| @@ -69,7 +69,7 @@ static ByteBuffer get_tx_context(HostContext context) { | |||
| } | |||
|
|
|||
| /** Get block hash callback function. */ | |||
| static ByteBuffer get_block_hash_fn(HostContext context, long number) { | |||
There was a problem hiding this comment.
Renamed this a the other ones don't have the _fn suffix.
Closed
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 23 23
Lines 3552 3552
Branches 376 376
=======================================
Hits 3298 3298
Misses 144 144
Partials 110 110 |
|
Will just merge this as it is a typo. |
|
Any regression test for this? |
|
Absolutely no tests for Java apparently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to have a typo triggering get_code_hash. Also removed the _fn suffix.
Pulled from #651.