Add evmc_is_abi_compatible helper #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
abi-version-helper
branch
4 times, most recently
from
8beaa15
to
9dc9b9a
Compare
Removing the pointer dereferencing from callers. The instance struct can be opaque from a callers perspective if using these helpers. |
axic
commented
Aug 20, 2018
include/evmc/helpers.h
Outdated
| /** | ||
| * Returns true if the instance has a compatible ABI version. | ||
| */ | ||
| static inline int evmc_has_compatible_abi(struct evmc_instance *instance) |
There was a problem hiding this comment.
Not sure about how to nicely name this function.
axic
force-pushed
the
abi-version-helper
branch
from
9dc9b9a
to
3fe4f28
Compare
axic
changed the title
chfast
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #67.