Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prague revision #683

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Add Prague revision #683

merged 1 commit into from
Feb 20, 2023

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Feb 16, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #683 (418461e) into master (b6a8a49) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   93.17%   93.15%   -0.02%     
==========================================
  Files          25       25              
  Lines        3779     3786       +7     
  Branches      391      394       +3     
==========================================
+ Hits         3521     3527       +6     
  Misses        147      147              
- Partials      111      112       +1     

@gumb0 gumb0 marked this pull request as ready for review February 16, 2023 15:17
@gumb0 gumb0 requested review from chfast and axic February 16, 2023 15:18
@gumb0 gumb0 force-pushed the prague branch 2 times, most recently from dab0e35 to eeb2c00 Compare February 16, 2023 15:54
@gumb0
Copy link
Member Author

gumb0 commented Feb 16, 2023

Not sure if I should bump the version in the same PR, maybe not.

@@ -5,6 +5,14 @@ Documentation of all notable changes to the **EVMC** project.
The format is based on [Keep a Changelog],
and this project adheres to [Semantic Versioning].

## [11.0.0] — unreleased
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we didn't bump in the past, just at the time of release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't bump it, just added a changelog.

CHANGELOG.md Outdated
### Added

- The Prague EVM revision (anticipated after Cancun)
[#XXX](https://github.com/ethereum/evmc/pull/XXX)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[#XXX](https://github.com/ethereum/evmc/pull/XXX)
[#683](https://github.com/ethereum/evmc/pull/683)

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming instruction metrics are unchanged from Cancun.

@gumb0 gumb0 merged commit 44fc118 into master Feb 20, 2023
@gumb0 gumb0 deleted the prague branch February 20, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants