Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Update compiler settings #685

Merged
merged 8 commits into from
Apr 18, 2023
Merged

cmake: Update compiler settings #685

merged 8 commits into from
Apr 18, 2023

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 24, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #685 (6eb0951) into master (44fc118) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6eb0951 differs from pull request most recent head 5c5f0db. Consider uploading reports for the commit 5c5f0db to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   93.15%   93.15%   -0.01%     
==========================================
  Files          25       25              
  Lines        3786     3782       -4     
  Branches      394      394              
==========================================
- Hits         3527     3523       -4     
  Misses        147      147              
  Partials      112      112              

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's draft but seems to pass tests?

@chfast
Copy link
Member Author

chfast commented Feb 26, 2023

It's draft but seems to pass tests?

Warnings are not treated as errors by default any more. So I will need to change this. The PR was to check if Cable update is not completely broken.

@chfast chfast force-pushed the compiler_settings branch 2 times, most recently from 005e55f to 157a488 Compare February 26, 2023 17:22
@chfast chfast force-pushed the compiler_settings branch 4 times, most recently from 1545c68 to ba540d2 Compare April 18, 2023 19:16
@chfast chfast marked this pull request as ready for review April 18, 2023 19:39
@chfast chfast merged commit 1f68cf7 into master Apr 18, 2023
@chfast chfast deleted the compiler_settings branch April 18, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants