Add refund to execution result in Go binding #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
May 6, 2023
There was a problem hiding this comment.
Hi @HerbertJordan, thanks for the contribution.
I'd rather change the existing API of Execute() to return Result as you proposed. What do you think?
|
Hi @chfast, thanks for reviewing this PR. If backward compatibility is not an issue, we should indeed update the existing |
HerbertJordan
force-pushed
the
herbert/include_refund_in_go_binding
branch
from
8e42f42
to
65da3fc
Compare
HerbertJordan
force-pushed
the
herbert/include_refund_in_go_binding
branch
from
65da3fc
to
153f1b0
Compare
HerbertJordan
force-pushed
the
herbert/include_refund_in_go_binding
branch
from
153f1b0
to
8b80acb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #690 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 25 25
Lines 3857 3857
Branches 396 396
=======================================
Hits 3606 3606
Misses 139 139
Partials 112 112 |
chfast
reviewed
Jul 31, 2023
HerbertJordan
force-pushed
the
herbert/include_refund_in_go_binding
branch
from
3073588
to
7641dfe
Compare
chfast
force-pushed
the
herbert/include_refund_in_go_binding
branch
from
7641dfe
to
c221cf2
Compare
chfast
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
Execute()function from the Go bindings to return aResultstruct instead of a list of result values to support the retrieval of the amount of refunded gas. This information is available in evmc.h's evmc_result, but was not exposed in the Go binding so far.