Go bindings: add missing error codes #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
Aug 20, 2018
bindings/go/evmc/evmc.go
Outdated
| @@ -120,7 +126,7 @@ func (err Error) Error() string { | |||
| return fmt.Sprintf("evmc: unknown internal error (%d)", int32(code)) | |||
There was a problem hiding this comment.
Maybe remove "unknown" from here as we do not predefine any internal errors at the moment.
There was a problem hiding this comment.
Perhaps "specific internal error" ? "user-defined internal error" ?
There was a problem hiding this comment.
I'd go with "internal error" only.
There was a problem hiding this comment.
Then the other internal error should also have a value IIRC.
chfast
requested changes
Aug 20, 2018
bindings/go/evmc/evmc.go
Outdated
| @@ -110,6 +110,12 @@ func (err Error) Error() string { | |||
| return "evmc: precompile failure" | |||
| case C.EVMC_CONTRACT_VALIDATION_FAILURE: | |||
| return "evmc: contract validation failure" | |||
| case C.EVMC_ARGUMENT_OUT_RANGE: | |||
There was a problem hiding this comment.
Should be EVMC_ARGUMENT_OUT_OF_RANGE. See Go CI builds.
There was a problem hiding this comment.
Fixed already, just didn't push before the other one is decided.
Merged
chfast
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.