Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EIP-3198: BASEFEE opcode #333

Merged
merged 4 commits into from
May 28, 2021
Merged

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented May 27, 2021

EVMC change: ethereum/evmc#603.

@yperbasis yperbasis requested a review from chfast May 27, 2021 11:15
@chfast chfast marked this pull request as ready for review May 28, 2021 13:56
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #333 (be0bdd1) into master (8d6a2ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          28       29    +1     
  Lines        3979     3999   +20     
=======================================
+ Hits         3970     3990   +20     
  Misses          9        9           
Flag Coverage Δ
consensus 94.89% <0.00%> (-0.41%) ⬇️
unittests 99.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/evmone/instructions.cpp 100.00% <ø> (ø)
lib/evmone/baseline.cpp 99.82% <100.00%> (+<0.01%) ⬆️
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)
test/unittests/evm_eip3198_basefee_test.cpp 100.00% <100.00%> (ø)

@chfast chfast merged commit 4d4dea3 into ethereum:master May 28, 2021
@chfast chfast deleted the eip-3198 branch May 28, 2021 14:16
@chfast chfast mentioned this pull request May 28, 2021
yperbasis added a commit to erigontech/silkworm that referenced this pull request May 28, 2021
yperbasis added a commit to erigontech/silkworm that referenced this pull request May 30, 2021
* EIP-3198: BASEFEE opcode

* Preliminary support for London consensus tests

* Revert to upstream evmc as ethereum/evmc/pull/603 is merged now

* Switch back to upstream evmone as ethereum/evmone/pull/333 is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants