Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication for engine api #167

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Authentication for engine api #167

merged 6 commits into from
Feb 8, 2022

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jan 24, 2022

Follow-up to #162 .

Differences:

  • Added that we're using the 'next' port,
  • Added section about claims, and added two more optional claims.

Todo:

  • examples
  • reference the authentication.md from the main page

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general! left a few nits

src/engine/authentication.md Outdated Show resolved Hide resolved
src/engine/authentication.md Outdated Show resolved Hide resolved
src/engine/authentication.md Outdated Show resolved Hide resolved
@djrtwo
Copy link
Contributor

djrtwo commented Jan 25, 2022

spellcheck is complaining about all of the acronyms used here.

Seems like we need to add them to the wordslist -- https://github.com/ethereum/execution-apis/blob/main/wordlist.txt

Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I left a few nits and question. Also, a general thing, IMO we should add an ## Authentication section to the main specification and reference this document. This section may contain keypoints like CLI param, port, and a short description of the approach i.e. JWT reference.

src/engine/authentication.md Show resolved Hide resolved
src/engine/authentication.md Outdated Show resolved Hide resolved
src/engine/authentication.md Outdated Show resolved Hide resolved
src/engine/authentication.md Outdated Show resolved Hide resolved
src/engine/authentication.md Show resolved Hide resolved
src/engine/authentication.md Outdated Show resolved Hide resolved
src/engine/authentication.md Outdated Show resolved Hide resolved
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Merging in next 24 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants