-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
witness: exhaustive check fixes #876
Merged
spencer-tb
merged 12 commits into
ethereum:block-witness-check-full-exhaustive
from
jsign:jsign-exhaustive-fixes
Oct 7, 2024
Merged
witness: exhaustive check fixes #876
spencer-tb
merged 12 commits into
ethereum:block-witness-check-full-exhaustive
from
jsign:jsign-exhaustive-fixes
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
force-pushed
the
jsign-exhaustive-fixes
branch
from
October 4, 2024 23:41
1c431c1
to
439458d
Compare
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
spencer-tb
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks :D
spencer-tb
merged commit Oct 7, 2024
de2bb1e
into
ethereum:block-witness-check-full-exhaustive
1 of 3 checks passed
spencer-tb
added a commit
that referenced
this pull request
Oct 7, 2024
* chore: add exhaustive witness checks. * chore: sys contract hack for test_selfdestruct. * chore: sys contract hack for test_extcodesize. * chore: sys contract hack for test_codecopy_ext_precompile. * witness: exhaustive check fixes (#876) * skip temporarily test Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: call tests fixes Signed-off-by: Ignacio Hagopian <[email protected]> * uncomment Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: fix codecopy tests Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: contract execution test fix Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: value bearing CALL with non existent account fixes Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: extcodesize test fixes Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: coinbase test fix Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: balance instruction test fixes Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: 2935-contract execution fixes Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: extcodesize insufficient gas fixes Signed-off-by: Ignacio Hagopian <[email protected]> * eip4762: create with big calldata test fixes Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]> Co-authored-by: Ignacio Hagopian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes to pass stricter exhaustive checks.
Must use gballet/go-ethereum#505 for filling.