Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

witness: exhaustive check fixes #876

Conversation

jsign
Copy link
Collaborator

@jsign jsign commented Oct 4, 2024

This PR contains fixes to pass stricter exhaustive checks.

Must use gballet/go-ethereum#505 for filling.

Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign jsign requested a review from spencer-tb October 5, 2024 14:26
@jsign jsign marked this pull request as ready for review October 5, 2024 14:26
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :D

@spencer-tb spencer-tb merged commit de2bb1e into ethereum:block-witness-check-full-exhaustive Oct 7, 2024
1 of 3 checks passed
spencer-tb added a commit that referenced this pull request Oct 7, 2024
* chore: add exhaustive witness checks.

* chore: sys contract hack for test_selfdestruct.

* chore: sys contract hack for test_extcodesize.

* chore: sys contract hack for test_codecopy_ext_precompile.

* witness: exhaustive check fixes (#876)

* skip temporarily test

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: call tests fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* uncomment

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: fix codecopy tests

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: contract execution test fix

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: value bearing CALL with non existent account fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: extcodesize test fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: coinbase test fix

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: balance instruction test fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: 2935-contract execution fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: extcodesize insufficient gas fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* eip4762: create with big calldata test fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants