Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC9 changes to P2P #240

Closed
14 tasks done
fjl opened this issue Jan 6, 2015 · 5 comments
Closed
14 tasks done

PoC9 changes to P2P #240

fjl opened this issue Jan 6, 2015 · 5 comments
Assignees
Milestone

Comments

@fjl
Copy link
Contributor

fjl commented Jan 6, 2015

PoC 8 (E.T.A mid Feburary) introduces RLPX, a new encrypted, authenticated and properly framed transport protocol for the P2P layer.

The current revision of the RLPX specification is here.

The PoC 8 document is on etherpad.

The changes are

Tasks beyond basic implementation

  • CLI flags for system-testing
    • -bootnodes
    • -nodekey
  • Port mapping integration for p2p/discover
  • A replacement for cmd/peerserver that can be used as Kademlia bootstrap node
  • Make UDP tests in package p2p/discover more reliable
  • Improve network UI in Mist

Remaining Tasks for PoC9

@fjl fjl added this to the PoC8 milestone Jan 6, 2015
@fjl fjl self-assigned this Jan 6, 2015
This was referenced Jan 6, 2015
@obscuren obscuren modified the milestone: PoC8 Jan 6, 2015
@obscuren
Copy link
Contributor

@fjl please update

@fjl
Copy link
Contributor Author

fjl commented Jan 30, 2015

updated. will update more often.

@fjl
Copy link
Contributor Author

fjl commented Feb 7, 2015

We now have a basic version that implements the features above.
The merge into develop will need coordination among implementations because
of its effect on the test network.

I will work on ironing out bugs for now.

@fjl
Copy link
Contributor Author

fjl commented Feb 7, 2015

Added some more tasks. These will have to go into #292 because we can't merge yet.

@obscuren obscuren modified the milestones: PoC8, Frontier Mar 9, 2015
@fjl fjl changed the title PoC8 changes to P2P PoC9 changes to P2P Mar 9, 2015
@fjl
Copy link
Contributor Author

fjl commented May 4, 2015

done

@fjl fjl closed this as completed May 4, 2015
@fjl fjl removed the in progress label May 4, 2015
markya0616 pushed a commit to getamis/go-ethereum that referenced this issue Jan 31, 2018
Remove mention of old `quorum` api in README.md
nonsense added a commit to nonsense/go-ethereum that referenced this issue Feb 9, 2018
…-node

Fix discovery tests to run with all adapters - sim, sock, exec
ngtuna added a commit to ngtuna/tomochain that referenced this issue Nov 10, 2018
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Aug 13, 2021
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this issue Aug 1, 2023
recordingdb: add config, trie flush, and metrics
rjl493456442 pushed a commit to rjl493456442/go-ethereum that referenced this issue Aug 29, 2023
Squash the main verkle PR ahead of rebase

don't call Bytes() in GetTreeKey (ethereum#137)

trie: avoid endianness conversion in GetTreeKey (ethereum#140)

* trie/utils: add concrete expected value in trie key generation test

Signed-off-by: Ignacio Hagopian <[email protected]>

* mod: update to latest go-verkle

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/utils: avoid endianness conversions

Signed-off-by: Ignacio Hagopian <[email protected]>

* apply review changes & update to official go-verkle version

Signed-off-by: Ignacio Hagopian <[email protected]>

Signed-off-by: Ignacio Hagopian <[email protected]>

upgrade go-verkle to CoW version and get TestProcessVerkle to build (ethereum#138)

updating ci to use self-hosted machine (ethereum#143)

fix: storage offset in non-header group + reuse of value buffer (ethereum#145)

dedup call to ChunkifyCode, same as replay branch (ethereum#156)

* dedup call to ChunkifyCode, same as replay branch

* fix some linter issues

fix code offset in tree update (ethereum#157)

fix REVERT in state processor test execution (ethereum#158)

* fix code offset in tree update

* fix REVERT in test execution

save on key hashing: lump code size update with first code chunk group (ethereum#159)

fix code chunk key calculation and storage key calculation (ethereum#161)

* fix codeKey calculation

* Remove

* fix storageOffset

* fix the fix to the fix to the offset fix

* Remove copy/pasted, unused code in test

* fix linter

---------

Co-authored-by: Guillaume Ballet <[email protected]>

fix: infinite loop when calling extcodecopy on empty code (ethereum#151)

upgrade to latest go-verkle

fix: only update code in the tree if it's dirty (ethereum#174)

fix: read-touch the code size and Keccak of the origin (ethereum#175)

List of changes for converting a sepolia database (ethereum#182)

* naive conversion rebased on top of beverly hills

* changes for the sepolia shadow fork conversion

* fixes to please the linter

* fixes to please the linter

Unified point cache (ethereum#180)

* Unified point cache

* Use cache for Try*Account

* alter Trie interface to use caching for slots (ethereum#181)

* alter Trie interface to use caching for slots

* fix: use a lock to protect the point cache (ethereum#185)

* use fastest non-master go-verkle version & pull trie/Verkle.go changes to use new api (ethereum#184)

* mod: update to fastest go-verkle version today

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/verkle: use new batch serialization api

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

* fix: TryDelete signature in unit tests

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

trie/utils: fix potential overflow (ethereum#191)

* trie/utils: fix potential overflow

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/utils: receive storage key as a byte slice

Signed-off-by: Ignacio Hagopian <[email protected]>

* revert formatter changes

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/utils: fix mod 256

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

trie/utils: fix incorrect bigint assignment (ethereum#193)

Signed-off-by: Ignacio Hagopian <[email protected]>

upgrade precomp link to fix CI

fix: add missing code size&keccak leaves in empty accounts (ethereum#192)

fixes to use the latest go-verkle@master (ethereum#197)

* fixes to use the latest go-verkle@master

* linter fixes

* linter fixes for tests

* fix: use jsign's go-verkle fix

refactor: remove unused (*StateDB).GetXLittleEndian methods (ethereum#204)

fix gas accounting issue in state_processor_test.go (ethereum#207)

update go-verkle not to use StatelessNode anymore (ethereum#206)

* update go-verkle not to use StatelessNode anymore

* update go-verkle to latest

refactor: move verkle gas accounting to its own block in TransitionDB (ethereum#208)

fix a panic in deserializeVerkleProof if GetProofItems returns a nil ProofElements

use the cachingDB instead of a custom VerkleDB (ethereum#209)

* use the cachingDB instead of a custom VerkleDB

* fix stack trace in LES

remove holiman from CODEOWNERS as he gets too many emails

read from tree in state object if the snapshot is nil (ethereum#205)

add missing error checks for the root node type (ethereum#214)

implement OpenStorageTrie for verkle trees (ethereum#210)

* implement OpenStorageTrie for verkle trees

* add a few comments for future maintenance

* fix linter issue

fix: copy balance leaf to new buffer in TryGetAccount (ethereum#217)

implement some heretofore unimplemented iterator methods (ethereum#219)

params: move verkle params to their own file (ethereum#228)

fix: proper number of chunk evals (ethereum#215)

overlay transition (ethereum#244)

* overlay transition

Fix some bugs identified in the code review

Co-authored-by: Ignacio Hagopian <[email protected]>

Include base -> overlay key-values migration logic (ethereum#199)

* mod: add go-verkle version with key-value migration new apis

Signed-off-by: Ignacio Hagopian <[email protected]>

* core/stateprocessor: use constant for max number of migrated key-values

Signed-off-by: Ignacio Hagopian <[email protected]>

* core: add base->overlay key-values migration logic

Signed-off-by: Ignacio Hagopian <[email protected]>

* core: fix some compiler errors

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie: consider removing transition trie api in the future

Signed-off-by: Ignacio Hagopian <[email protected]>

* mod: use latest go-verkle

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

fix some unit tests errors

get convresion block from file

fix compilation issues

fix initialization issue in migrator

fix: changes needed to run the first 28 blocks

important sutff: fix the banner

fix: use nonce instead of balance in nonce leaf (ethereum#202)

fixes for performing the overlay transition (ethereum#203)

* fixes for performing the overlay transition

* fixes for the full replay

* fix: deletion-and-recreation of EoA

* fixes to replay 2M+ blocks

* upgrade to go-verkle@master

* fix: proper number of chunk evals

* rewrite conversion loop to fix known issues

changes to make replay work with the overlay method (ethereum#216)

* fixes for performing the overlay transition

fixes for the full replay

fix: deletion-and-recreation of EoA

fixes to replay 2M+ blocks

upgrade to go-verkle@master

fix: proper number of chunk evals

rewrite conversion loop to fix known issues

changes to make replay work with the overlay method

fixes to replay 2M+ blocks

update to latest go-verkle@master

* use a PBSS-like scheme for internal nodes (ethereum#221)

* use a PBSS-like scheme for internal nodes

* a couple of fixes coming from debugging replay

* fix: use an error to notify the transition tree that a deleted account was found in the overlay tree (ethereum#222)

* fixes for pbss replay (ethereum#227)

* fixes for pbss replay

* trie/verkle: use capped batch size (ethereum#229)

* trie/verkle: use capped batch size

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/verkle: avoid path variable allocation per db.Put

Signed-off-by: Ignacio Hagopian <[email protected]>

* don't keep more than 32 state root conversions in RAM (ethereum#230)

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Guillaume Ballet <[email protected]>

* cleanup some code

* mod: update go-verkle

Signed-off-by: Ignacio Hagopian <[email protected]>

* re-enable snapshot (ethereum#231)

* re-enable cancun block / snapshot (ethereum#226)

* clear storage conversion key upon translating account (ethereum#234)

* clear storage conversion key upon translating account

* mod: use latest go-verkle

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

* fix: self-deadlock with translated root map mutex (ethereum#236)

* return compressed commitment as root commitment (ethereum#237)

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

fix first panic in *TransitionTrie.Copy()

upgrade go-verkle to latest master

mod: update go-verkle (ethereum#239)

Signed-off-by: Ignacio Hagopian <[email protected]>

core: print state root every 100 blocks (ethereum#240)

Signed-off-by: Ignacio Hagopian <[email protected]>

fix: only Commit the account trie (ethereum#242)

fixes to get TestProcessVerkle to work with the overlay branch (ethereum#238)

* fixes to get TestProcessVerkle to work with the overlay branch

* fix all panics in verkle state processor test

* fix proof verification

move transition management to cachingDB

* fix: mark the verkle transition as started if it's ended without being started

* fix the verkle state processing test

* fix linter errors

* Add a function to clear verkle params for replay

* fix: handle TransitionTrie in OpenStorageTrie

* fix linter issue

* fix the deleted account error (ethereum#247)

* code cleanup (ethereum#248)

* fix: don't error on a missing conversion.txt (ethereum#249)

* Overlay Tree preimages exporting and usage (ethereum#246)

* export overlay preimages tool

Signed-off-by: Ignacio Hagopian <[email protected]>

* use preimages flat file in overlay tree migration logic

Signed-off-by: Ignacio Hagopian <[email protected]>

* cmd/geth: add --roothash to overlay tree preimage exporting command

Signed-off-by: Ignacio Hagopian <[email protected]>

* cleanup

Signed-off-by: Ignacio Hagopian <[email protected]>

* review feedback

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

* fix: reduce the PR footprint (ethereum#250)

* fix: don't fail when preimages.bin is missing (ethereum#251)

* fix: don't fail when preimages.bin is missing

* fix: don't open the preimages file when outside of transition

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

review changes

remove replay-specific code
weiihann pushed a commit to weiihann/go-ethereum that referenced this issue Sep 27, 2023
Squash the main verkle PR ahead of rebase

don't call Bytes() in GetTreeKey (ethereum#137)

trie: avoid endianness conversion in GetTreeKey (ethereum#140)

* trie/utils: add concrete expected value in trie key generation test

Signed-off-by: Ignacio Hagopian <[email protected]>

* mod: update to latest go-verkle

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/utils: avoid endianness conversions

Signed-off-by: Ignacio Hagopian <[email protected]>

* apply review changes & update to official go-verkle version

Signed-off-by: Ignacio Hagopian <[email protected]>

Signed-off-by: Ignacio Hagopian <[email protected]>

upgrade go-verkle to CoW version and get TestProcessVerkle to build (ethereum#138)

updating ci to use self-hosted machine (ethereum#143)

fix: storage offset in non-header group + reuse of value buffer (ethereum#145)

dedup call to ChunkifyCode, same as replay branch (ethereum#156)

* dedup call to ChunkifyCode, same as replay branch

* fix some linter issues

fix code offset in tree update (ethereum#157)

fix REVERT in state processor test execution (ethereum#158)

* fix code offset in tree update

* fix REVERT in test execution

save on key hashing: lump code size update with first code chunk group (ethereum#159)

fix code chunk key calculation and storage key calculation (ethereum#161)

* fix codeKey calculation

* Remove

* fix storageOffset

* fix the fix to the fix to the offset fix

* Remove copy/pasted, unused code in test

* fix linter

---------

Co-authored-by: Guillaume Ballet <[email protected]>

fix: infinite loop when calling extcodecopy on empty code (ethereum#151)

upgrade to latest go-verkle

fix: only update code in the tree if it's dirty (ethereum#174)

fix: read-touch the code size and Keccak of the origin (ethereum#175)

List of changes for converting a sepolia database (ethereum#182)

* naive conversion rebased on top of beverly hills

* changes for the sepolia shadow fork conversion

* fixes to please the linter

* fixes to please the linter

Unified point cache (ethereum#180)

* Unified point cache

* Use cache for Try*Account

* alter Trie interface to use caching for slots (ethereum#181)

* alter Trie interface to use caching for slots

* fix: use a lock to protect the point cache (ethereum#185)

* use fastest non-master go-verkle version & pull trie/Verkle.go changes to use new api (ethereum#184)

* mod: update to fastest go-verkle version today

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/verkle: use new batch serialization api

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

* fix: TryDelete signature in unit tests

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

trie/utils: fix potential overflow (ethereum#191)

* trie/utils: fix potential overflow

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/utils: receive storage key as a byte slice

Signed-off-by: Ignacio Hagopian <[email protected]>

* revert formatter changes

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/utils: fix mod 256

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

trie/utils: fix incorrect bigint assignment (ethereum#193)

Signed-off-by: Ignacio Hagopian <[email protected]>

upgrade precomp link to fix CI

fix: add missing code size&keccak leaves in empty accounts (ethereum#192)

fixes to use the latest go-verkle@master (ethereum#197)

* fixes to use the latest go-verkle@master

* linter fixes

* linter fixes for tests

* fix: use jsign's go-verkle fix

refactor: remove unused (*StateDB).GetXLittleEndian methods (ethereum#204)

fix gas accounting issue in state_processor_test.go (ethereum#207)

update go-verkle not to use StatelessNode anymore (ethereum#206)

* update go-verkle not to use StatelessNode anymore

* update go-verkle to latest

refactor: move verkle gas accounting to its own block in TransitionDB (ethereum#208)

fix a panic in deserializeVerkleProof if GetProofItems returns a nil ProofElements

use the cachingDB instead of a custom VerkleDB (ethereum#209)

* use the cachingDB instead of a custom VerkleDB

* fix stack trace in LES

remove holiman from CODEOWNERS as he gets too many emails

read from tree in state object if the snapshot is nil (ethereum#205)

add missing error checks for the root node type (ethereum#214)

implement OpenStorageTrie for verkle trees (ethereum#210)

* implement OpenStorageTrie for verkle trees

* add a few comments for future maintenance

* fix linter issue

fix: copy balance leaf to new buffer in TryGetAccount (ethereum#217)

implement some heretofore unimplemented iterator methods (ethereum#219)

params: move verkle params to their own file (ethereum#228)

fix: proper number of chunk evals (ethereum#215)

overlay transition (ethereum#244)

* overlay transition

Fix some bugs identified in the code review

Co-authored-by: Ignacio Hagopian <[email protected]>

Include base -> overlay key-values migration logic (ethereum#199)

* mod: add go-verkle version with key-value migration new apis

Signed-off-by: Ignacio Hagopian <[email protected]>

* core/stateprocessor: use constant for max number of migrated key-values

Signed-off-by: Ignacio Hagopian <[email protected]>

* core: add base->overlay key-values migration logic

Signed-off-by: Ignacio Hagopian <[email protected]>

* core: fix some compiler errors

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie: consider removing transition trie api in the future

Signed-off-by: Ignacio Hagopian <[email protected]>

* mod: use latest go-verkle

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

fix some unit tests errors

get convresion block from file

fix compilation issues

fix initialization issue in migrator

fix: changes needed to run the first 28 blocks

important sutff: fix the banner

fix: use nonce instead of balance in nonce leaf (ethereum#202)

fixes for performing the overlay transition (ethereum#203)

* fixes for performing the overlay transition

* fixes for the full replay

* fix: deletion-and-recreation of EoA

* fixes to replay 2M+ blocks

* upgrade to go-verkle@master

* fix: proper number of chunk evals

* rewrite conversion loop to fix known issues

changes to make replay work with the overlay method (ethereum#216)

* fixes for performing the overlay transition

fixes for the full replay

fix: deletion-and-recreation of EoA

fixes to replay 2M+ blocks

upgrade to go-verkle@master

fix: proper number of chunk evals

rewrite conversion loop to fix known issues

changes to make replay work with the overlay method

fixes to replay 2M+ blocks

update to latest go-verkle@master

* use a PBSS-like scheme for internal nodes (ethereum#221)

* use a PBSS-like scheme for internal nodes

* a couple of fixes coming from debugging replay

* fix: use an error to notify the transition tree that a deleted account was found in the overlay tree (ethereum#222)

* fixes for pbss replay (ethereum#227)

* fixes for pbss replay

* trie/verkle: use capped batch size (ethereum#229)

* trie/verkle: use capped batch size

Signed-off-by: Ignacio Hagopian <[email protected]>

* trie/verkle: avoid path variable allocation per db.Put

Signed-off-by: Ignacio Hagopian <[email protected]>

* don't keep more than 32 state root conversions in RAM (ethereum#230)

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Guillaume Ballet <[email protected]>

* cleanup some code

* mod: update go-verkle

Signed-off-by: Ignacio Hagopian <[email protected]>

* re-enable snapshot (ethereum#231)

* re-enable cancun block / snapshot (ethereum#226)

* clear storage conversion key upon translating account (ethereum#234)

* clear storage conversion key upon translating account

* mod: use latest go-verkle

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

* fix: self-deadlock with translated root map mutex (ethereum#236)

* return compressed commitment as root commitment (ethereum#237)

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

fix first panic in *TransitionTrie.Copy()

upgrade go-verkle to latest master

mod: update go-verkle (ethereum#239)

Signed-off-by: Ignacio Hagopian <[email protected]>

core: print state root every 100 blocks (ethereum#240)

Signed-off-by: Ignacio Hagopian <[email protected]>

fix: only Commit the account trie (ethereum#242)

fixes to get TestProcessVerkle to work with the overlay branch (ethereum#238)

* fixes to get TestProcessVerkle to work with the overlay branch

* fix all panics in verkle state processor test

* fix proof verification

move transition management to cachingDB

* fix: mark the verkle transition as started if it's ended without being started

* fix the verkle state processing test

* fix linter errors

* Add a function to clear verkle params for replay

* fix: handle TransitionTrie in OpenStorageTrie

* fix linter issue

* fix the deleted account error (ethereum#247)

* code cleanup (ethereum#248)

* fix: don't error on a missing conversion.txt (ethereum#249)

* Overlay Tree preimages exporting and usage (ethereum#246)

* export overlay preimages tool

Signed-off-by: Ignacio Hagopian <[email protected]>

* use preimages flat file in overlay tree migration logic

Signed-off-by: Ignacio Hagopian <[email protected]>

* cmd/geth: add --roothash to overlay tree preimage exporting command

Signed-off-by: Ignacio Hagopian <[email protected]>

* cleanup

Signed-off-by: Ignacio Hagopian <[email protected]>

* review feedback

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

* fix: reduce the PR footprint (ethereum#250)

* fix: don't fail when preimages.bin is missing (ethereum#251)

* fix: don't fail when preimages.bin is missing

* fix: don't open the preimages file when outside of transition

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>

review changes

remove replay-specific code
atenjin pushed a commit to alt-research/go-ethereum that referenced this issue Apr 4, 2024
…polia-release

Update superchain-reg dependency for OP Sepolia Ecotone activation
luanxu-mxc pushed a commit to MXCzkEVM/mxc-geth that referenced this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants