build dependency download URL contains invalid control character

[AwaitFuture]

System information

OS: Windows 10
Geth version: Master branch
Go version: go1.21.6 windows/amd64
commit hash: 2e947b7

Expected behaviour

make test should download all dependencies and build without issue.

Actual behaviour

>>> "C:\\Program Files\\Go\\bin\\go" build -ldflags "-X github.com/ethereum/go-ethereum/internal/version.gitCommit=2e947b7a0041f087ce4945303f3dd267b6296a14 -X github.com/ethereum/go-ethereum/internal/version.gitDate=20240127" -tags urfave_cli_no_docs,ckzg -trimpath -v -o F:\geth\go-ethereum\build\bin\rlpdump.exe ./cmd/rlpdump
github.com/ethereum/go-ethereum/cmd/rlpdump
go run build/ci.go test
build\cache\fixtures_develop.tar.gz is stale
/fixtures_develop.tar.gz/github.com/ethereum/execution-spec-tests/releases/download/v1.0.6
ci.go:349: download error: parse "https://github.com/ethereum/execution-spec-tests/releases/download/v1.0.6\r/fixtures_develop.tar.gz": net/url: invalid control character in URL
exit status 1
make: *** [Makefile:20: test] Error 1

Steps to reproduce the behaviour

make clean
make test

Solution

changing ci.go line 346 to:

url := fmt.Sprintf("https://github.com/ethereum/execution-spec-tests/releases/download/v%s/%s%s", strings.TrimSpace(executionSpecTestsVersion), base, ext)

was enough to solve the problem; should probably trim all version strings to avoid strange whitespace issues in the future.

[holiman]

Thanks,
Yes, this is the culprit

// MustLoadChecksums loads a file containing checksums.
func MustLoadChecksums(file string) *ChecksumDB {
	content, err := os.ReadFile(file)
	if err != nil {
		log.Fatal("can't load checksum file: " + err.Error())
	}
	return &ChecksumDB{strings.Split(string(content), "\n")}
}

(along with git's ability to reformat files from linux-encoding to windows-encoding)

fix is to use strings.Split(strings.ReplaceAll(string(content), "\r\n", "\n"), "\n")