Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_getFilterLogs returns logs in reversed order #855

Closed
frozeman opened this issue May 5, 2015 · 1 comment
Closed

eth_getFilterLogs returns logs in reversed order #855

frozeman opened this issue May 5, 2015 · 1 comment
Labels
area:rpc type:feature

Comments

@frozeman
Copy link
Contributor

frozeman commented May 5, 2015

When you call eth_getFilterLogs and you get a bunch of logs back, they are ordered from the latest to the oldest one.

They should be ordered from the oldest to the latest one though.
CPP does it and its also more logical.

In web3.js we call eth_getFilterLogs before polling with eth_getFilterChanges. So currently using go as node the order you get is for example:

  • log from block 200
  • log from block 150
  • log from block 30
  • (start now polling for new logs)
  • log from block 210
  • log from block 240

CPP has it the other way around and its also more logical going from oldest to newest.
@frozeman frozeman added the RPC label May 5, 2015
@frozeman frozeman added this to the Frontier milestone May 5, 2015
@obscuren
Copy link
Contributor

obscuren commented May 5, 2015

I consider this to be none-blocking for frontier (and also an enhancement)

@obscuren obscuren removed this from the Frontier milestone May 5, 2015
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
@jfoutts-celo
Relax TestPeriodicRoundChanges requiring next round to within two rou…
9150ceb 
…nds (ethereum#855)

* Relax TestPeriodicRoundChanges requirement on next round to within two rounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rpc type:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamschmideg @frozeman @obscuren