internal/ethapi: fix getTransactionReceipt #16217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2018
fjl
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a half revert of #15665.
The original issue the above PR was meant to fix is the graceful handling of some database corruption where a receipt was missing. Unfortunately the PR broke our RPC APIs.
In Go world it generally makes sense to return an
errorif something is not found, but the RPC API doesn't have standardized errors speced. Every tool assumes that if the thing requested is not available,nullis returned. The above PR broke this. This PR tries to fix it.Note: It is debatable whether or not the spec should be changed, but we should conform to the spec and the expected behavior, not the "clean" behavior unfortunately.
Fixes #16213
Fixes #16092