core: differentiate receipt concensus and storage decoding #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Thu Oct 8 08:52:02 UTC 2015 |
|
@obscuren @fjl @Gustav-Simonsson Please take a close look at this. |
| } | ||
|
|
||
| type Logs []*Log | ||
|
|
||
| // LogForStorage is a wrapper around a Log that flattens and parses the entire | ||
| // content of a log, opposed to only the consensus fields originally (by hiding |
There was a problem hiding this comment.
should probably be as opposed to
|
@karalabe rebase please |
|
Not really worth it. This code is already contained within the fast sync PR, but it already diverged a bit from that due to originally conflicting when rebasing on the old develop. Rebasing would just add a lot more conflicts down the line to the fast sync. As I'm very close to finalizing the fast sync PR, I'll just close this and merge this code along with the remaining things from #1839. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the necessary modifications to make Receipts and Logs transferable over the network. Previously the decoders always expected a full storage version, which obviously won't happen over the network, so we need to explicitly decode database contents as storage receipts/logs, and leave the plain receipts/logs to decode as only the consensus fields.