Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: estimate gas usage automatically. #19508

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

rjl493456442
Copy link
Member

@rjl493456442 rjl493456442 commented Apr 29, 2019

This PR introduces functionality to enable gas estimation for transaction signing or sending.

Currently, the gas is not specified, then geth will use a hardcoded value(90k) as the default gas value. In this PR, geth will use EstimateGas function instead.

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants