Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethclient, internal/ethapi: add support for EIP-695 (eth_chainId) #19694

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Jun 11, 2019

EIP-695 was written in 2017. Parity and Infura have support for this
method and we should, too.

EIP-695 was written in 2017. Parity and Infura have support for this
method and we should, too.
@karalabe karalabe added this to the 1.9.0 milestone Jun 11, 2019
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe merged commit 2b54666 into ethereum:master Jun 11, 2019
Copy link

@omar1326 omar1326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants