-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth, eth/tracers: expose gas used in tx to js tracer #22038
Merged
holiman
merged 7 commits into
ethereum:master
from
s1na:gasprice-available-to-vm-tracer
Dec 27, 2020
Merged
eth, eth/tracers: expose gas used in tx to js tracer #22038
holiman
merged 7 commits into
ethereum:master
from
s1na:gasprice-available-to-vm-tracer
Dec 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth/tracers: include tx gas in tracers usedGas eth/tracers: fix prestate tracer's sender balance eth/tracers: rm unnecessary import eth/tracers: pass intrinsicGas separately to tracer eth/tracers: fix tests broken by lack of txdata eth, eth/tracers: minor fix
holiman
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- I pushed a commit to un-export the struct used in testing, and also added a testcase for some basic sanity-checking of the feature.
Strikes me now though that the tests can be simplified even more...
Pushed another commit to remove some of the boilerplate |
18d89f5
to
87dffcf
Compare
9 tasks
9 tasks
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #21553 (fixes #20537). It exposes two new parameters
gasPrice
andintrinsicGas
to js tracers. Using these two and the already exposedgasUsed
they can calculate how much the sender spent on gas.