all: implement eip-1559 #22837

holiman · 2021-05-07T08:23:17Z

This is @lightclient 's work on 1559, but squashed. The reason for squashing it is simply that it makes it easier to rebase when the master changes.
Also, making the PR from holiman makes it possible for geth-maintainers to push to the repo.

core/state_transition.go

holiman · 2021-05-07T10:04:03Z

This PR, I think, erroneously would accept type=2 transactions too early, before the fork block. It extends the eip2930Signer to be able to handle those types.
Running the cmd/evm/testdata/9 input on Berlin now does not throw an error in the state_transition, which is fine, but it should still throw an error due to including type=2 transactions before London.

@fjl , do you think we should extend the signers so we have a londonSigner which allows type=2, or should we explicitly check the tx type somewhere else?

holiman · 2021-05-07T10:37:46Z

New london signer
TODO: investigate if effective gas price in state transition is correct or not

fjl · 2021-05-07T11:14:15Z

Yes, we need a new signer every time a new tx type is added. This is also why I added the LatestSigner and related functionality. It is used across the codebase now, so you only need to update it in core/types.

core/types: add back gasPrice core/types: add base fee to block params: add eip-1559 constants consensus: verify base fee calculation consensus: swap out custom max fn for common.math impl params,consensus: add test fork Aleut core: implement gas accounting for txs after eip-1559 accounts,interfaces,internal: tweak msg interface to support feeCap + tip core: add base fee to effective gas price core/types: add 1559 header serialization and block test all: e2e test for eip-1559 plus some bug fixes consensus: add test for block elasticity consensus: add basefee to sealing hash and fix off-by-one bug in transition consensus: check 1559 headers in clique consensus/clique: update seal hasher to include basefee core/types: fix 1559 signing hash core: appease linter core/vm: add base fee opcode all: add comments and misc clean up core/types: rename to DynamicFeeTx internal/ethapi: add missing new msg parameter consensus/misc/eip1559: improve logging Co-authored-by: Marius van der Wijden <[email protected]> core/evm: default baseFee to 0 even when inactive core/consensus: add license text to eip1559 files core/types: update license date and simplify newmessage func params/config: update aleut chainid consensus/misc/eip1559: reduce big int allocations core/state_processor: fix block elasticity core/state_transition: throw if baseFee is invalid cmd/evm: add eip-1559 support for t8n core/types: add aliases for tip and feeCap json unmarshallers to match spec consensus/misc/eip1559: better invalid baseFee error msg core/evm: don't initialize basefee unless header includes it core,eth,les: calculate effective gas price in tx.AsMessage(..) consensus/misc/eip1559: check that base fee is not nil tests/init: add new aluet testing configs core/types/transaction_signing: update ACL reference in comment to AL core,consensus: pass in chain config to eip1559 functions all: clean up rebase params/config: update baikal london block to 500 consensus: verify basefee not defined before clique fork, imporve errors cmd/evm: account for elasticity parameter in gas limit core: name base fee errors

consensus/clique/clique.go

params/config.go

… target

holiman · 2021-05-07T14:47:26Z

This PR now has support for the new changes in EIP-1559: ethereum/EIPs#3552 . Cherry-picked from quilt, credits @lightclient

(I haven't really tested/reviewed it, please help checking it)

cmd/evm/internal/t8ntool/execution.go

cmd/evm/internal/t8ntool/stenv_marshalling.go

consensus/misc/eip1559.go

holiman · 2021-05-07T15:02:33Z

I think we should add some tests for the gasLimit and gasTarget behaviours.

Edit: Done

holiman force-pushed the 1559_squashed branch from 7745858 to 89d23da Compare May 7, 2021 08:55

holiman commented May 7, 2021

View reviewed changes

core/state_transition.go Show resolved Hide resolved

holiman force-pushed the 1559_squashed branch from f1454d7 to 6b279b1 Compare May 7, 2021 11:02

holiman marked this pull request as ready for review May 7, 2021 12:07

holiman requested review from gballet, karalabe, MariusVanDerWijden, rjl493456442 and zsfelfoldi as code owners May 7, 2021 12:07

holiman mentioned this pull request May 7, 2021

London hardfork tracker #22736

Closed

lightclient and others added 6 commits May 7, 2021 14:46

core: remove header-checks in state transition

502a383

core/types: dynamicfeetx, make gasPrice return feeCap

dab16dc

core/types: use new signer for london

4007eb7

core/types: update LatestSigner methods to use london signer

d3e468d

core/types: use RLP optional field support for BaseFee

30bc255

fjl force-pushed the 1559_squashed branch from 7567089 to 30bc255 Compare May 7, 2021 12:47

holiman commented May 7, 2021

View reviewed changes

consensus/clique/clique.go Show resolved Hide resolved

fjl reviewed May 7, 2021

View reviewed changes

params/config.go Outdated Show resolved Hide resolved

holiman and others added 3 commits May 7, 2021 16:23

core: clean up + add testcases for new core errors

418099b

core,consensus: revert block gas limit to mean limit rather than 1559…

2f826d0

… target

consensus: minor refactor

642b970

lightclient reviewed May 7, 2021

View reviewed changes

cmd/evm/internal/t8ntool/execution.go Outdated Show resolved Hide resolved

lightclient reviewed May 7, 2021

View reviewed changes

cmd/evm/internal/t8ntool/stenv_marshalling.go Outdated Show resolved Hide resolved

holiman commented May 7, 2021

View reviewed changes

consensus/misc/eip1559.go Outdated Show resolved Hide resolved

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024

all: implement eip-1559 (ethereum#22837)

f94585b

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024

all: implement eip-1559 (ethereum#22837)

697e93a

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024

all: implement eip-1559 (ethereum#22837)

a082617

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024

all: implement eip-1559 (ethereum#22837)

9e2f69a

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024

all: implement eip-1559 (ethereum#22837)

bba9cd5

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024

all: implement eip-1559 (ethereum#22837)

0365cc1

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024

all: implement eip-1559 (ethereum#22837)

ffa6acb

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024

all: implement eip-1559 (ethereum#22837)

fb15801

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024

all: implement eip-1559 (ethereum#22837)

70d1943

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024

all: implement eip-1559 (ethereum#22837)

76f3590

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024

all: implement eip-1559 (ethereum#22837)

53ddd16

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024

all: implement eip-1559 (ethereum#22837)

4ef140e

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024

all: implement eip-1559 (ethereum#22837)

bfc6584

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024

all: implement eip-1559 (ethereum#22837)

5710d26

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024

all: implement eip-1559 (ethereum#22837)

f8efb14

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024

all: implement eip-1559 (ethereum#22837)

77e3fc0

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024

all: implement eip-1559 (ethereum#22837)

65b906e

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024

all: implement eip-1559 (ethereum#22837)

4e2e4ef

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024

all: implement eip-1559 (ethereum#22837)

ff693c9

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024

all: implement eip-1559 (ethereum#22837)

f4e7539

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024

all: implement eip-1559 (ethereum#22837)

b8b05d3

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024

all: implement eip-1559 (ethereum#22837)

1bf3813

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024

all: implement eip-1559 (ethereum#22837)

7582b80

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024

all: implement eip-1559 (ethereum#22837)

36974a0

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024

all: implement eip-1559 (ethereum#22837)

f0ecb6d

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024

all: implement eip-1559 (ethereum#22837)

ff7aedd

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024

all: implement eip-1559 (ethereum#22837)

3aa58f3

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024

all: implement eip-1559 (ethereum#22837)

dc93c42

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024

all: implement eip-1559 (ethereum#22837)

e18553b

wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024

all: implement eip-1559 (ethereum#22837)

f4d1e8c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: implement eip-1559 #22837

all: implement eip-1559 #22837

holiman commented May 7, 2021

holiman commented May 7, 2021

holiman commented May 7, 2021 •

edited

Loading

fjl commented May 7, 2021 •

edited

Loading

holiman commented May 7, 2021 •

edited

Loading

holiman commented May 7, 2021 •

edited

Loading

all: implement eip-1559 #22837

all: implement eip-1559 #22837

Conversation

holiman commented May 7, 2021

holiman commented May 7, 2021

holiman commented May 7, 2021 • edited Loading

fjl commented May 7, 2021 • edited Loading

holiman commented May 7, 2021 • edited Loading

holiman commented May 7, 2021 • edited Loading

holiman commented May 7, 2021 •

edited

Loading

fjl commented May 7, 2021 •

edited

Loading

holiman commented May 7, 2021 •

edited

Loading

holiman commented May 7, 2021 •

edited

Loading