-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/types: revert receipts changes #23247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 00b922f.
This reverts commit 7522642.
…oding (ethereum#22852)" This reverts commit 643fd0e.
s1na
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Also tried the branch on a recently synced node (which doesn't have legacy logs) and it seems to run smoothly
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Jul 28, 2021
* Revert "core/types: go generate (ethereum#23177)" This reverts commit 00b922f. * Revert "core/types: remove LogForStorage type (ethereum#23173)" This reverts commit 7522642. * Revert "core/types: remove support for legacy receipt/log storage encoding (ethereum#22852)" This reverts commit 643fd0e.
skb-cyber
reviewed
Jul 30, 2021
@@ -17,8 +17,11 @@ | |||
package types | |||
|
|||
import ( | |||
"io" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20 + com
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
* Revert "core/types: go generate (ethereum#23177)" This reverts commit 00b922f. * Revert "core/types: remove LogForStorage type (ethereum#23173)" This reverts commit 7522642. * Revert "core/types: remove support for legacy receipt/log storage encoding (ethereum#22852)" This reverts commit 643fd0e.
This was referenced Sep 23, 2022
holiman
pushed a commit
that referenced
this pull request
Dec 3, 2022
This PR drops the legacy receipt types, the freezer-migrate command and the startup check. The previous attempt #22852 at this failed because there were users who still had legacy receipts in their db, so it had to be reverted #23247. Since then we added a command to migrate legacy dbs #24028. As of the last hardforks all users either must have done the migration, or used the --ignore-legacy-receipts flag which will stop working now.
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
This PR drops the legacy receipt types, the freezer-migrate command and the startup check. The previous attempt ethereum#22852 at this failed because there were users who still had legacy receipts in their db, so it had to be reverted ethereum#23247. Since then we added a command to migrate legacy dbs ethereum#24028. As of the last hardforks all users either must have done the migration, or used the --ignore-legacy-receipts flag which will stop working now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts three PRs for removing legacy scheme support.
This PR also fixes #23245