Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/fuzzers: fix go vet warning about signature of ReadByte #23380

Merged
merged 1 commit into from
Aug 24, 2021
Merged

tests/fuzzers: fix go vet warning about signature of ReadByte #23380

merged 1 commit into from
Aug 24, 2021

Conversation

baptiste-b-pegasys
Copy link
Contributor

go vet show a signature warning

go vet ./...
# github.com/ethereum/go-ethereum/cmd/devp2p/internal/ethtest
cmd/devp2p/internal/ethtest/chain.go:42:17: method WriteTo(writer io.Writer) error should have signature WriteTo(io.Writer) (int64, error)

I propose to fix that by making the function private.

holiman
holiman approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl added this to the 1.10.9 milestone Aug 24, 2021
@fjl fjl changed the title tests/fuzzers: fix: go vet warning signature tests/fuzzers: fix go vet warning about signature of ReadByte Aug 24, 2021
@fjl fjl merged commit 5cee33e into ethereum:master Aug 24, 2021
@fjl fjl removed the pr:merge label Aug 24, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 24, 2021
@baptiste-b-pegasys
tests/fuzzers: fix go vet warning about ReadByte (ethereum#23380)
8aa1f5d
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@baptiste-b-pegasys @zzyalbert
tests/fuzzers: fix go vet warning about ReadByte (ethereum#23380)
bc4b8d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.9
Development

Successfully merging this pull request may close these issues.
4 participants
@baptiste-b-pegasys @holiman @fjl @MariusVanDerWijden