Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: add go:build lines #23468

Merged
merged 1 commit into from
Aug 25, 2021
Merged

all: add go:build lines #23468

merged 1 commit into from
Aug 25, 2021

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Aug 25, 2021

go1.17 fmt ./...

@fjl
all: add go:build lines
cd2c4bb 
go1.17 fmt ./...
@fjl fjl mentioned this pull request Aug 25, 2021
Closed
karalabe
karalabe reviewed Aug 25, 2021
View reviewed changes
accounts/keystore/watch.go
@@ -14,6 +14,7 @@
// You should have received a copy of the GNU Lesser General Public License
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.

//go:build (darwin && !ios && cgo) || freebsd || (linux && !arm64) || netbsd || solaris
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, paranthesis, amazeballs

@karalabe karalabe added this to the 1.10.9 milestone Aug 25, 2021
karalabe
karalabe approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume Go's logic is good enough for me not to check it :P

@fjl fjl merged commit 8a13401 into ethereum:master Aug 25, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 25, 2021
@fjl
all: add go:build lines (ethereum#23468)
520914e 
Generated by go1.17 fmt ./...
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@fjl @zzyalbert
all: add go:build lines (ethereum#23468)
c2a5add 
Generated by go1.17 fmt ./...
@gzliudan gzliudan mentioned this pull request May 15, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@ligi ligi Awaiting requested review from ligi

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.9
Development

Successfully merging this pull request may close these issues.
2 participants
@fjl @karalabe