-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/devp2p/internal/ethtest: only use eth66 if eth66 is negotiated #23568
Conversation
start := time.Now() | ||
for time.Since(start) < timeout { | ||
c.SetReadDeadline(time.Now().Add(5 * time.Second)) | ||
switch msg := c.Read().(type) { | ||
case *Ping: | ||
case Ping: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks like it either makes something that didn't work, work, or vice versa. What's that about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, yes it fixes something, but I accidentally fixed it in the wrong method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read66 returns GetBlockHeaders
instead of *GetBlockHeaders
which is returned by 65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…thereum#23568) * cmd/devp2p/internal/ethtest: only use eth66 if eth66 is negotiated * cmd/devp2p/internal/ethtest: switch on concrete type not pointer * cmd/devp2p/internal/ethtest: switch on concrete type not pointer
Fixes an issue where we send 65 style messages over a 66 connection