Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/filters: fix TestPendingLogsSubscription #23619

Merged
merged 1 commit into from
Oct 4, 2021
Merged

eth/filters: fix TestPendingLogsSubscription #23619

merged 1 commit into from
Oct 4, 2021

Conversation

mirokuratczyk
Copy link
Contributor

  • Fix test finishing before goroutines complete and passing even though it should fail
  • Update test to match that FromBlock and ToBlock are no longer ignored
  • New test cases

@mirokuratczyk
eth/filters: fix test
a8a19a9 
* Fix test finishing before goroutines complete and passing even though it should fail
* Update test to match that FromBlock and ToBlock are no longer ignored
* New test cases
@fjl fjl self-requested a review September 24, 2021 17:43
@fjl fjl self-assigned this Sep 28, 2021
@fjl fjl removed the status:triage label Sep 28, 2021
@fjl fjl changed the title eth/filters: fix test eth/filters: fix TestPendingLogsSubscription Oct 4, 2021
@fjl fjl added this to the 1.10.10 milestone Oct 4, 2021
@fjl fjl merged commit 5a0e1d8 into ethereum:master Oct 4, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 4, 2021
@mirokuratczyk
eth/filters: fix TestPendingLogsSubscription (ethereum#23619)
af88206 
The test did not synchronize with per-case goroutines, and thus didn't notice
that some tests were just hanging. This change adds missing synchronization
and fixes the broken tests.
@holiman holiman mentioned this pull request Nov 2, 2021
Merged
6 tasks
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@mirokuratczyk @zzyalbert
eth/filters: fix TestPendingLogsSubscription (ethereum#23619)
29bc434 
The test did not synchronize with per-case goroutines, and thus didn't notice
that some tests were just hanging. This change adds missing synchronization
and fixes the broken tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@fjl fjl Awaiting requested review from fjl

Assignees

@fjl fjl

Labels
None yet
Projects
None yet
Milestone
1.10.10
Development

Successfully merging this pull request may close these issues.
3 participants
@mirokuratczyk @fjl @ligi